-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single Lesson: Polish the design #2862
Conversation
Thanks for keeping on this. Happy to defer to Francisco on the color styles, where the green doesn't match the blue from the referenced issue, but was introduced by the larger visual refresh. Can work well. I know this is probably tricky, but would it be possible to get the rounded pill-shape on the green bar here? |
Yes, exactly. Nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work cleaning this up! One comment on the sidebar icon alignment above.
I feel that it can be as wide as the border just like other progress bars are. What do you think? @fcoveram |
I think Francisco changed this, and I'm happy to defer to him. No blockers on that detail if this was part of the design. |
5b00a9f
to
709cdd6
Compare
709cdd6
to
424a82d
Compare
Actions Style Updates
For the quiz single page actions, I will open another PR to address their style updates, as in Sensei, the components there cannot easily be separated and moved into Learn without making things overly complex. Creating a PR directly in Sensei will be cleaner and easier to understand. (Issue was created for tracking) Update
|
Completed Notice
|
Sign-in Block Updates This will be addressed in another PR, as it's slightly more complicated. |
Preview Mode Pending feedback. |
@adamwoodnz I think this PR is ready for review again, and you can start from this comment. I have documented all the changes that are based on the latest design in separate comments, each with screenshots and relevant commits. Thanks 🙏 The following items will be handled separately later:
|
a8dbb4f
to
44fbab0
Compare
b095bf1
to
06eeda5
Compare
This PR has quite a few commits. If there are no issues at the moment, I plan to merge it first and handle the remaining parts and the latest design updates in other PRs. |
3f1f25b
to
0dc0f03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work 🎸
Resolves #2638 #2809
This PR goes through the breadcrumbs, sidebar nav, and the main content style to make them align with the latest design, for both non-standalone and standalone lessons.
Non-Standalone
Standalone